Skip to content

Bug 1837122: templates: add etc-networkmanager-dispatcher.d-90-long-hostname.yaml #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 22, 2020
Merged

Bug 1837122: templates: add etc-networkmanager-dispatcher.d-90-long-hostname.yaml #1737

openshift-merge-robot merged 1 commit into from
May 22, 2020

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented May 18, 2020

This is an automated cherry-pick of #1711

/assign abhinavdahiya

templates: add etc-networkmanager-dispatcher.d-90-long-hostname.yaml
64f3702 
On GCP it is not uncommon to have DNS names that are too long.
Linux restricts the kernel hostname to being less than 63 characters.
The new template simply ensures that a hostname is set in the event that
NetworkManager is unable to do so.

Bug: 1809345
Signed-off-by: Ben Howard <ben.howard@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 18, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 18, 2020

@openshift-cherrypick-robot: Bugzilla bug 1809345 has been cloned as Bugzilla bug 1837122. Retitling PR to link against new bug.
/retitle [release-4.4] Bug 1837122: templates: add etc-networkmanager-dispatcher.d-90-long-hostname.yaml

Details

In response to this:

[release-4.4] Bug 1809345: templates: add etc-networkmanager-dispatcher.d-90-long-hostname.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] Bug 1809345: templates: add etc-networkmanager-dispatcher.d-90-long-hostname.yaml [release-4.4] Bug 1837122: templates: add etc-networkmanager-dispatcher.d-90-long-hostname.yaml May 18, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 18, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 18, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1837122, which is invalid:

  • expected dependent Bugzilla bug 1809345 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.4] Bug 1837122: templates: add etc-networkmanager-dispatcher.d-90-long-hostname.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sinnykumari
Copy link
Contributor

sinnykumari commented May 19, 2020

/retest

@sinnykumari
Copy link
Contributor

sinnykumari commented May 19, 2020

By looking at MCD log, e2e-gcp-op failure looks like another occurrence of bug https://bugzilla.redhat.com/show_bug.cgi?id=1827712 .

/retest

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented May 19, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 19, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 19, 2020

@abhinavdahiya: This pull request references Bugzilla bug 1837122, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.z) matches configured target release for branch (4.4.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1809345 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1809345 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
  • bug has dependents
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 19, 2020
@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented May 19, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 19, 2020

@abhinavdahiya: This pull request references Bugzilla bug 1837122, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.z) matches configured target release for branch (4.4.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1809345 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1809345 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
  • bug has dependents
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@darkmuggle
Copy link

darkmuggle commented May 19, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2020
@darkmuggle
Copy link

darkmuggle commented May 20, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: darkmuggle, openshift-cherrypick-robot, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@darkmuggle
Copy link

darkmuggle commented May 20, 2020

/skip ci/prow/e2e-aws-scaleup-rhel7

RHEL7 is not affected to this change.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 20, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented May 20, 2020

/skip

@openshift-bot
Copy link
Contributor

openshift-bot commented May 20, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented May 21, 2020

/retitle Bug 1837122: templates: add etc-networkmanager-dispatcher.d-90-long-hostname.yaml

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] Bug 1837122: templates: add etc-networkmanager-dispatcher.d-90-long-hostname.yaml Bug 1837122: templates: add etc-networkmanager-dispatcher.d-90-long-hostname.yaml May 21, 2020
@kikisdeliveryservice kikisdeliveryservice changed the title Bug 1837122: templates: add etc-networkmanager-dispatcher.d-90-long-hostname.yaml [release-4.4] Bug 1837122: templates: add etc-networkmanager-dispatcher.d-90-long-hostname.yaml May 21, 2020
@kikisdeliveryservice kikisdeliveryservice changed the title [release-4.4] Bug 1837122: templates: add etc-networkmanager-dispatcher.d-90-long-hostname.yaml Bug 1837122: templates: add etc-networkmanager-dispatcher.d-90-long-hostname.yaml May 21, 2020
@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 22, 2020
@openshift-ci-robot openshift-ci-robot mentioned this pull request May 22, 2020
Merged
@openshift-bot
Copy link
Contributor

openshift-bot commented May 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented May 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit cea63f1 into openshift:release-4.4 May 22, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 22, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/cluster-api-provider-gcp#91, openshift/machine-config-operator#1737. Bugzilla bug 1837122 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1837122: templates: add etc-networkmanager-dispatcher.d-90-long-hostname.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@ericavonb ericavonb Awaiting requested review from ericavonb

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

Assignees

@darkmuggle darkmuggle

@abhinavdahiya abhinavdahiya

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@openshift-cherrypick-robot @openshift-ci-robot @sinnykumari @abhinavdahiya @darkmuggle @openshift-bot @kikisdeliveryservice @sdodson @yuqi-zhang @openshift-merge-robot